Upload
byoenghan-baek
View
282
Download
2
Embed Size (px)
Citation preview
Tips for a successful code review
“Introduction to the Personal Software Process – PSP” by Watts S. Humphrey.
how can they achieve a level of code quality that causes pride among the professionals involved?
The answer: CODE REVIEW.
There are three types of code reviews:
pair programming,
formal code review,
lightweight code review.
benefit of code review
“good idea; bad execu-tion”
Worst code Review
intellectually vain can make code reviews a
nightmare of shouting and hurt feelings.
But despite all that they are very useful.
Learn to enjoy the code re-views.
how do we make code reviews use-ful?
Code reviews SHOULD’T be performed to find errors in the code.
Code reviews SHOULD’T be performed to enforce coding standards.
Keep a positive attitude. remember: you are not the code!
Time, Your coworkers are waiting for you.
Code writer (before code review)
1. Document 2. At least 2 days before3. Code revision number – JIRA open
Code writer (ing)
일단 각오해라 .
Reviewer
Ask questions rather than make statements.
Reviewer
Avoid the "Why" questions.
Reviewer
Make sure the discussion stays focused on the code and not the coder.
Standard / Checklist
Moderator
Beware the "Big Brother" effect.