Разбираем Massive View Controller

Александр Сычев Разработчик iOS

RAMBLER.iOS V

Как разобрать Massive View Controller и сделать из него VIPER-модуль

Massive View Controller -> VIPER

Проблемы Massive View Controller

Примеры

Немного статистики



Примеры



Dark Massive View Controller Light VIPER


Model View Controller

ModelView

Controller

Mediator Strategy

User action

Update

Update

Notify


Massive View Controller


•Высокая сложность поддержки и развития

•Высокий порог вхождения

•Слабо тестируем

•Невозможно переиспользовать

•Редактор притормаживает на 5 000 строк кода 😃

Недостатки Massive View Controller




Примеры





Переход между экранами


View Presenter Interactor Router



@protocol AGMainMenuControllerViewOutput <NSObject>

- (void)showMenuSectionWithType:(MainMenuSectionType)sectionType fromViewController:(UIViewController *)viewController;

@end




Handle event


- (void)showMenuSectionWithType:(MainMenuSectionType)sectionType fromViewController:(UIViewController *)viewController;

@end


- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath { NSInteger index = indexPath.row; [self.output showMenuSectionWithType:index fromViewController:self];}


Handle event


- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath { NSInteger index = indexPath.row; [self.output showMenuSectionWithType:index fromViewController:self];}


Handle eventTable delegate


@protocol AGMainMenuRouterInput <NSObject>

- (void)showCityFromViewController:(UIViewController *)vcS;- (void)showPlacesFromViewController:(UIViewController *)vcS;- (void)showReferenceBookFromViewController:(UIViewController *)vcS;

@end


Handle eventTable delegate


@protocol AGMainMenuRouterInput <NSObject>

- (void)showCityFromViewController:(UIViewController *)vcS;- (void)showPlacesFromViewController:(UIViewController *)vcS;- (void)showReferenceBookFromViewController:(UIViewController *)vcS;

@end


Handle eventTable delegate Module routing


- (void)showMenuSectionWithType:(MainMenuSectionType)sectionType fromViewController:(UIViewController *)viewController { switch (sectionType) { <Call RouterInput methods> }}




- (void)showMenuSectionWithType:(MainMenuSectionType)sectionType fromViewController:(UIViewController *)viewController { switch (sectionType) { <Call RouterInput methods> }}



Call Router


- (void)showCityFromViewController:(UIViewController *)vcS { UIStoryboard *sb = <Load storyboard>; UIViewController *vcD = <Instantiate ViewController>; [vcS.navigationController pushViewController:vcD animated:YES];}



Call Router



Massive View Controller VIPER


Чтение данных






- (void)obtainQuarters;

@end





- (void)obtainQuarters;

@end

Handle event


- (void)viewDidLoad { [super viewDidLoad]; [self.output obtainQuarters];}


Handle event


- (void)viewDidLoad { [super viewDidLoad]; [self.output obtainQuarters];}


Handle eventAsk for data


- (void)obtainQuarters { [self.view showSpinners]; [self.interactor loadQuarters];}




- (void)obtainQuarters { [self.view showSpinners]; [self.interactor loadQuarters];}



Call Interactor


- (void)loadQuarters { <Prepare loading request> NSArray *quarters = [AGQuarter MR_findAllSortedBy:sortTerm inContext:context]; NSArray *ponsoQuarters = [self createPlainObjectsFrom:quarters]; [self.output loadedQuarters:ponsoQuarters];}



Call Interactor


- (void)loadQuarters { <Prepare loading request> NSArray *quarters = [AGQuarter MR_findAllSortedBy:sortTerm inContext:context]; NSArray *ponsoQuarters = [self createPlainObjectsFrom:quarters]; [self.output loadedQuarters:ponsoQuarters];}



Call Interactor

Load data


- (void)loadedQuarters:(NSArray *)quarters { [self.view hideSpinners]; [self.view handleObtainedQuarters:quarters];}



Call Interactor

Load data


- (void)loadedQuarters:(NSArray *)quarters { [self.view hideSpinners]; [self.view handleObtainedQuarters:quarters];}



Call Interactor

Load data

Prepare data




Call Interactor

Load data

Prepare data

- (void)handleObtainedQuarters:(NSArray *)quarters { <Display quarters>}


- (void)handleObtainedQuarters:(NSArray *)quarters { <Display quarters>}



Call Interactor

Load data

Prepare data

Display data





Конфигурация объектов


AssemblyVIPER-модуль



@interface AGMainMenuInteractor : NSObject <AGMainMenuInteractorInput>

@property (weak) id<AGMainMenuInteractorOutput> output;

@property (strong) id<AGImageLocalCacheManager> imageLocalCacheManager;

@end



@interface AGMainMenuInteractor : NSObject <AGMainMenuInteractorInput>

@property (weak) id<AGMainMenuInteractorOutput> output;

@property (strong) id<AGImageLocalCacheManager> imageLocalCacheManager;

@end


Load image


- (AGMainMenuInteractor *)interactorMainMenu { return [TyphoonDefinition withClass:[AGMainMenuInteractor class] configuration:^(TyphoonDefinition *definition) { [definition injectProperty:@selector(imageLocalCacheManager) with:[self.coreHelpersAssembly imageLocalCacheManager]]; }];}


Load image


- (AGMainMenuInteractor *)interactorMainMenu { return [TyphoonDefinition withClass:[AGMainMenuInteractor class] configuration:^(TyphoonDefinition *definition) { [definition injectProperty:@selector(imageLocalCacheManager) with:[self.coreHelpersAssembly imageLocalCacheManager]]; }];}


Load image Configure Module


- (id<AGImageLocalCacheManager>)imageLocalCacheManager { return [TyphoonDefinition withClass:[AGImageLocalCacheManagerImplementation class] configuration:^(TyphoonDefinition *definition) { [definition useInitializer:@selector(managerWithFileManager:) parameters:^(TyphoonMethod *initializer) { [initializer injectParameterWith:[self fileManager]]; }]; }];}

CoreHelpersAssembly



Load image

Конфигурация объектов- (void)loadBackgroundImage { UIImage *guideBackgroundImage = [self.imageLocalCacheManager loadImageWithImageId:guide.backgroundImage.photoId]; [self.output loadedBackgroundImage:guideBackgroundImage];}

Configure Module



Use Core HelpersLoad image

Конфигурация объектов- (void)loadBackgroundImage { UIImage *guideBackgroundImage = [self.imageLocalCacheManager loadImageWithImageId:guide.backgroundImage.photoId]; [self.output loadedBackgroundImage:guideBackgroundImage];}

Configure Module

- (void)loadBackgroundImage { UIImage *guideBackgroundImage = [self.imageLocalCacheManager loadImageWithImageId:guide.backgroundImage.photoId]; [self.output loadedBackgroundImage:guideBackgroundImage];}





View

Interactor

Presenter

Router

Assembly


View

Interactor

Presenter

Router

Assembly


Трудозатраты

24 человеко-часа



Примеры



Статистика

MVC VIPERR1 ~9,3K / 0,175K ~18K / 0,58KR2 ~7,6K / 0,54K ~1,1K / 0,55KR3 ~3,8K / 0,38K ~8,4K / 0,53K


> 1,5 раза


Выводы

VIPER MVC


Спасибо за внимание!

Technology

Разбираем Massive View Controller